I admit I have only read about half of this thread so I thought I would give you my perspective on AOPA at this time. In 2004 I got back into flying and my wife took flying lessons for the first time. During that year I earned my private pilots license and we bought an airplane that I finished my training in and we kept and flew for 14 years.
Back in 2004 AOPA was a major advocate to help me make the decisions necessary to buy an airplane. They had purchasing advice and tutorials, they had purchasing appraisal arrangements and financing, and they had flight insurance. Now granted all these various services were in various different sections of AOPA but all of them were opened to me with my membership card. Fast forward 15 years, and none of these services were readily available or at competitive pricing enough to make it worthwhile for me to use AOPA for any part of my next airplane purchase. It's like they have forgotten that we exist and still want their help.
I do still currently have an AOPA membership but the only perk that I see, and it's not really that much of a perk, is the legal aid part of the membership. Rental cars from airports are expensive and AOPA membership doesn't really do much for that. AOPA aircraft insurance isn't any better than you can get anywhere else and they don't call you back readily. AOPA aircraft financing might as well not even exist, I went through a third party aviation loan broker to purchase my bird.
When you call them the friendly helpful people that you talked to a decade ago don't answer the phone, don't know anything, and don't care. From a point of view of customer service I would give them a zero except for renewing your membership, in which case they do that exceptionally well. Maybe they're advocacy is good and they are doing the things they say but how do you know? From the few times I have contacted them for specialized services that they at one time promoted, they appear to be a broken organization. I must not be the only one that sees it that way because they're down from a high of 400,000 members to about 250,000. Those numbers indicate that there is something seriously wrong with AOPA