I had a friend buy me something AOPA related about 20 years ago, a sweatshirt I think, but that is all I can think of.
I strongly suspect the biggest market for AOPA stuff is AOPA headquarters.
Logo merchandise doesn't cost much, beyond the cost of the clothing itself. I paid a ~$100 artwork fee to the local embroidery shop for a design for work, and since then, we've had ~100 golf shirts, t-shirts, sweatshirts, and fleecies made up...in order sizes ranging from 10 to 25 units.
So it's not like having logo merchandise available costs much. Using someplace like Sporty's as a go-between gets a better rate (since the go-between can order a lot more shirts, etc. since they do multiple logo) and keeps AOPA from having to have anybody handle the mechanical details.
Sporty's loses any prestige of being AOPA's official merchandise source, and AOPA loses the advertising benefit of being featured in Sporty's catalog. In reality, Sporty's is acting as the go-between to the actual embroiderers and loses whatever "cut" they got of each sale. But, as been mentioned, the number of orders was probably fairly low to start with, and AOPA will regain the advertising benefit because of the new vendor.
Income-wise, it's probably a very minor hit for Sporty's.
Ron Wanttaja